Removing internal use of id_order in to_adjlist #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
========================================
+ Coverage 78.6% 78.7% +0.1%
========================================
Files 122 122
Lines 13185 13182 -3
========================================
+ Hits 10365 10371 +6
+ Misses 2820 2811 -9
|
knaaptime
approved these changes
Jan 16, 2023
|
This will probably need to be revised as it broke tests in esda pysal/esda#239 and momepy pysal/momepy#461 |
|
See the reproducer in pysal/momepy#461 (comment) |
|
At least the one in momepy is fixed by #511 (haven't seen that before). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to deprecate
id_orderin the future, so the internal use here can be removed to address #507.