Skip to content
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

Fix dateformat timedimension #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

igorpojzl
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Metabase generates wrong dateformat for timedimension #68

@pyrooka pyrooka marked this pull request as ready for review April 22, 2020 13:54
@pyrooka
Copy link
Owner

pyrooka commented Apr 22, 2020

Some queries still generate the wrong filter. Please check these cases:


Filter: on
E.g.: Character S. Birth is April 22, 2020
Query:

{
  "dimension": "Characters.birth",
  "dateRange": [
    "2020-04-22T00:00:00Z",
    "2020-04-23T00:00:00Z"
  ]
}

Filter: between
E.g.: Character S. Birth between April 1, 2020 April 3, 2020
Query:

{
  "dimension": "Characters.birth",
  "dateRange": [
    "2020-04-01T00:00:00Z",
    "2020-04-04T00:00:00Z"
  ]
}

@igorpojzl
Copy link
Contributor Author

I will check it out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants