-
Notifications
You must be signed in to change notification settings - Fork 219
MNT: replace black and isort with ruff format and lint #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: replace black and isort with ruff format and lint #1496
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
==========================================
+ Coverage 96.50% 96.56% +0.06%
==========================================
Files 20 20
Lines 1830 1833 +3
==========================================
+ Hits 1766 1770 +4
+ Misses 64 63 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -8,15 +8,6 @@ repos: | |||
- id: check-yaml | |||
- id: end-of-file-fixer | |||
- id: trailing-whitespace | |||
- repo: https://github.com/psf/black-pre-commit-mirror |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay removing isort. However, I am not sure about black. Do the formatters conflict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ruff formatter is a drop-in replacement for Black, but much faster (100x). According to these docs "> 99.9% of lines are formatted identically", so this may explain some minor differences of formatting found in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds worth a try. Can always swap it back later. Probably should remove the black badge in the readme.
Thanks @mwtoews 👍 |
This maintenance PR does the following: