Update pyproject.toml validation
#4344
Conversation
abravalheri
force-pushed
the
update-validate-pyproject
branch
from
d2b092d to
0576d60
Compare
| if typing.TYPE_CHECKING: | ||
| import sys | ||
|
|
||
| if sys.version_info < (3, 11): | ||
| from typing_extensions import Self | ||
| else: | ||
| from typing import Self |
There was a problem hiding this comment.
To be fixed upstream, but this double check is redundant!
| if typing.TYPE_CHECKING: | |
| import sys | |
| if sys.version_info < (3, 11): | |
| from typing_extensions import Self | |
| else: | |
| from typing import Self | |
| if typing.TYPE_CHECKING: | |
| from typing_extensions import Self |
There was a problem hiding this comment.
Not sure if I introduced this one myself, but I think I get why it is there... Probably the intention is this code to allow automatic update (using either ruff or pyupgrade) once Python 3.11 comes and remove typing_extensions when viable?
I agree that is not needed, but I would not worry too much about it.
There was a problem hiding this comment.
Yeah it's minor. Type-checkers will still understand it and typing_extensions is still not used at runtime.
If it's just an artefact of code generation logic it doesn't hurt, just redundant.
According to review suggestion Co-authored-by: Avasam <samuel.06@hotmail.com>
There was a problem hiding this comment.
Thank you very much @Avasam for having a look. Let's see how the CI reacts to the changes, sometimes I have the impression that it is a cat/mouse game with mypy...
| if typing.TYPE_CHECKING: | ||
| import sys | ||
|
|
||
| if sys.version_info < (3, 11): | ||
| from typing_extensions import Self | ||
| else: | ||
| from typing import Self |
There was a problem hiding this comment.
Not sure if I introduced this one myself, but I think I get why it is there... Probably the intention is this code to allow automatic update (using either ruff or pyupgrade) once Python 3.11 comes and remove typing_extensions when viable?
I agree that is not needed, but I would not worry too much about it.
Summary of changes
validate-pyprojectmypy.ini(¿shouldn't*._validate_pyproject.*already be excluded?)Closes #4341
Pull Request Checklist
newsfragments/.(See documentation for details)