[Testing] Provide a CI check for disallowed code changes #3579
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Sep 27, 2022
webknjaz
reviewed
Sep 27, 2022
webknjaz
reviewed
Sep 27, 2022
webknjaz
reviewed
Sep 27, 2022
webknjaz
reviewed
Sep 27, 2022
|
@mohitsaxenaknoldus FYI the PR needs improvements before it's acceptable. |
mohitsaxenaknoldus
force-pushed
the
issue3428
branch
from
d0ed221 to
6f7dd7c
Compare
Sorry for the delay, I've done the requested changes. Please take a look now, |
jaraco
force-pushed
the
main
branch
3 times, most recently
from
a85759c to
93ce5a0
Compare
jaraco
approved these changes
Dec 16, 2022
mohitsaxenaknoldus
requested review from
jaraco and
webknjaz
and removed request for
webknjaz and
jaraco
webknjaz
reviewed
Dec 22, 2022
webknjaz
reviewed
Dec 22, 2022
webknjaz
reviewed
Dec 22, 2022
webknjaz
reviewed
Dec 22, 2022
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
reviewed
Dec 22, 2022
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
reviewed
Dec 23, 2022
webknjaz
reviewed
Dec 23, 2022
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
|
@webknjaz Please check again. |
webknjaz
reviewed
Dec 27, 2022
|
I saw you deleted the name, how about adding an accurate one? |
Added better names. |
webknjaz
approved these changes
Dec 27, 2022
|
@mohitsaxenaknoldus This currently has conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #3428
Pull Request Checklist
changelog.d/.(See documentation for details)