fix bug: obs_indx -> obs_ind and improve PyMCModel._data_setter
#462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 94.66% 94.67%
=======================================
Files 32 32
Lines 2195 2196 +1
=======================================
+ Hits 2078 2079 +1
Misses 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NathanielF
approved these changes
Apr 21, 2025
causalpy/pymc_models.py
Outdated
| @@ -111,7 +122,7 @@ def fit(self, X, y, coords: Optional[Dict[str, Any]] = None) -> None: | |||
| ) | |||
| return self.idata | |||
|
|
|||
| def predict(self, X): | |||
| def predict(self, X: np.ndarray): | |||
There was a problem hiding this comment.
Is the type hint needed or always necessary?
There was a problem hiding this comment.
It's not necessary, but in an upcoming PR, the X will be an xarray.DataArray` just for the synthetic control experiment. So at that point I was going to elaborate the type hints further. Goal was just to make it more explicit.
Maybe I'll remove this for now and just introduce type hints if/when the function starts to really need it for keeping readability high.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obs_indxtoobs_ind#459PyMCModel._data_setterto make it work📚 Documentation preview 📚: https://causalpy--462.org.readthedocs.build/en/462/