Skip to content

Separate InterruptedTimeSeries and SyntheticControl classes, update uml #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025

Conversation

drbenvincent
Copy link
Collaborator

@drbenvincent drbenvincent commented Apr 19, 2025

Closes #457

As well as running the tests locally, I also ran all relevant notebooks to check for no errors. But I'm not updating the notebooks here because the API is unchanged and the results should be identical


📚 Documentation preview 📚: https://causalpy--458.org.readthedocs.build/en/458/

@drbenvincent drbenvincent added the refactor Refactor, clean up, or improvement with no visible changes to the user label Apr 19, 2025
@drbenvincent drbenvincent changed the title separate InterruptedTimeSeries and SyntheticControl classes, update uml Separate InterruptedTimeSeries and SyntheticControl classes, update uml Apr 19, 2025
Copy link

codecov bot commented Apr 19, 2025

Codecov Report

Attention: Patch coverage is 97.48428% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.66%. Comparing base (4227edf) to head (867d93b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
causalpy/experiments/interrupted_time_series.py 97.01% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   94.53%   94.66%   +0.13%     
==========================================
  Files          31       32       +1     
  Lines        2068     2195     +127     
==========================================
+ Hits         1955     2078     +123     
- Misses        113      117       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drbenvincent drbenvincent merged commit a39e015 into main Apr 19, 2025
9 checks passed
@drbenvincent drbenvincent deleted the sc-class-extraction branch April 19, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor, clean up, or improvement with no visible changes to the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate SyntheticControl and InterruptedTimeSeries classes, removing the PrePostFit abstract class
2 participants