Skip to content

fixes for uml github action #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2025
Merged

fixes for uml github action #446

merged 7 commits into from
Apr 4, 2025

Conversation

drbenvincent
Copy link
Collaborator

@drbenvincent drbenvincent commented Mar 28, 2025

  • updates pyproject.toml to include pylint (which contains pyreverse) in the optional docs dependencies
  • updates the makefile to load the docs optional dependencies

📚 Documentation preview 📚: https://causalpy--446.org.readthedocs.build/en/446/

@drbenvincent drbenvincent added the devops DevOps related label Mar 28, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project configuration to support UML workflows by refining optional dependencies used for documentation generation.

  • Adds pylint (providing pyreverse) to the docs dependencies in pyproject.toml.
  • Updates the makefile to load the docs optional dependencies.
Files not reviewed (1)
  • Makefile: Language not supported

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (9d5e0f0) to head (437c99f).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          31       31           
  Lines        1985     1985           
=======================================
  Hits         1874     1874           
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@williambdean williambdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Did the manual trigger work?

@drbenvincent
Copy link
Collaborator Author

drbenvincent commented Apr 4, 2025

Seems good. Did the manual trigger work?

Just tried that and no luck https://github.com/pymc-labs/CausalPy/actions/runs/14260986935/job/39972351813

But trying a couple of things...

@drbenvincent
Copy link
Collaborator Author

No luck on a manual run https://github.com/pymc-labs/CausalPy/actions/runs/14261271099/job/39973210151 Seems like pylint is not being installed correctly because it's not recognising the pyreverse command

@williambdean
Copy link
Contributor

Maybe try python -m pyreverse

@drbenvincent
Copy link
Collaborator Author

Maybe try python -m pyreverse

So that doesn't work locally, so not sure it would help. But I've added a debug step

      - name: Debug pyreverse installation
        run: |
          python -m pip show pylint
          which pyreverse
          pyreverse --version || echo "pyreverse not found"

which results in WARNING: Package(s) not found: pylint. So there's an issue with the install

@drbenvincent
Copy link
Collaborator Author

That last commit worked. it seems to require explicit installation of pyreverse.

@drbenvincent drbenvincent changed the title fixes for uml workflow fixes for uml github action Apr 4, 2025
@drbenvincent drbenvincent merged commit 2f34ec6 into main Apr 4, 2025
9 checks passed
@drbenvincent drbenvincent deleted the uml-workflow-fix branch April 4, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants