Skip to content

automate UML diagrams #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented Jul 30, 2024

Closes #178


📚 Documentation preview 📚: https://causalpy--395.org.readthedocs.build/en/395/

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (77058ee) to head (59a4624).
Report is 141 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   85.60%   94.35%   +8.75%     
==========================================
  Files          22       30       +8     
  Lines        1716     1967     +251     
==========================================
+ Hits         1469     1856     +387     
+ Misses        247      111     -136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@williambdean
Copy link
Contributor Author

williambdean commented Aug 1, 2024

Where does the pyreverse command come from? pylint, right? Is this part of either the environment or pyproject dependencies?

EDIT: Added to docs

@williambdean
Copy link
Contributor Author

pre-commit.ci autofix

@williambdean
Copy link
Contributor Author

Having some permission issues. Not sure what is up @drbenvincent
Might have to alter the pymc-marketing one as well

Copy link
Collaborator

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Looks good, but I guess we just need to figure out the permissions issue. Left some comments

on:
pull_request:
branches: [main]
# paths:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, at end since the files that changed wouldn't trigger this action

# - "causalpy/**"
push:
branches: [main]
# paths:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code?

with:
python-version: "3.10"

- name: Configure Git Identity
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very much a beginner when it comes to GitHub actions, but I've not seen anything about coffin of git identity in the other workflows. Could this be related to the permissions issue?

Or is it required for the later pushed changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for pushing later.

Could be cause of permission. Not sure at the moment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it might be if repo doesn't allow for bots to push code. I am seeing that the pre-commit bot didn't push either though the command was recognized

@williambdean
Copy link
Contributor Author

@drbenvincent do you allow bots in the code base? I am noticing that the precommit auto fix didnt make a commit either

@williambdean
Copy link
Contributor Author

Can you check in https://github.com/pymc-labs/CausalPy/settings/actions that "Workflow permissions" include "Read and write permissions"
@drbenvincent

@drbenvincent
Copy link
Collaborator

Sorry for delay. Will focus on this ASAP.


steps:
- name: Checkout repository
uses: actions/checkout@v2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this needs to be v4

@williambdean
Copy link
Contributor Author

Had some issues in pymc marketing
pymc-labs/pymc-marketing#913

@drbenvincent
Copy link
Collaborator

Can you check in https://github.com/pymc-labs/CausalPy/settings/actions that "Workflow permissions" include "Read and write permissions" @drbenvincent

Current settings are as below. Let me know if I need to update anything.
Screenshot 2024-08-06 at 20 28 35

@williambdean
Copy link
Contributor Author

Can you check in https://github.com/pymc-labs/CausalPy/settings/actions that "Workflow permissions" include "Read and write permissions" @drbenvincent

Current settings are as below. Let me know if I need to update anything. Screenshot 2024-08-06 at 20 28 35

Thanks for checking this @drbenvincent

I was able to figure it out. Based on it coming from a fork.

Waiting for passing then can add back commented code

@williambdean
Copy link
Contributor Author

Thoughts on the options: Run only on:

  1. on all pushes, if the repo owner is pymc-labs (not run during forks) but then also on merge to main
  2. merge to main

In either way, it will be updated.

What are your thoughts?

Here is the other option: pymc-labs/pymc-marketing#967 (comment)

@williambdean
Copy link
Contributor Author

This has deviated a bit from how it is (tried) to be done in PyMC-Marketing:

@williambdean williambdean deleted the automate-uml branch February 28, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate UML image generation
2 participants