Skip to content

run madx for getsuper in modeldir #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

run madx for getsuper in modeldir #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e7ac6a
run madx for getsuper in modeldir
awegsche Sep 21, 2023
75287ed
absolute paths, move symlink creation
awegsche Nov 29, 2023
d1ae4cb
remove ineffective check
awegsche Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions GetLLM/getsuper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,6 @@ def check_input(opt):
# files
if "source_files" not in opt or len(opt.source_files) < 2:
raise ValueError("Provide at least two source files!")
for f_name in opt.source_files:

if not os.path.isfile(f_name) and not os.path.isfile(f_name + '.gz') and not os.path.isfile(f_name + '.clean') and not os.path.isfile(f_name + '.sdds'):
raise ValueError(f_name + ' does not exist')

if "twissfile" not in opt:
raise ValueError("Twissfile needed for execution.")
Expand Down Expand Up @@ -197,25 +193,28 @@ def main(**kwargs):
if 0 not in files_dict:
raise ValueError("NO DPP=0.0. Provide at least one source file with DPP=0.0.")

accel_inst = _create_accel_instance(options.accel_cls, files_dict, options.output_path,
output_path = os.path.abspath(options.output_path)

accel_inst = _create_accel_instance(options.accel_cls, files_dict, output_path,
options.twissfile)

_create_models_by_madx(accel_inst, files_dict.keys())


for dpp in files_dict:
files = files_dict[dpp]
twiss_dpp_path = _join_with_output_path(options.output_path, "twiss_{:f}.dat".format(dpp))
twiss_dpp_path = _join_with_output_path(output_path, "twiss_{:f}.dat".format(dpp))
_rungetllm(twiss_dpp_path, files, dpp,
options.output_path, accel_inst, options.algorithm)
output_path, accel_inst, options.algorithm)

# The GUI wants the default files to have the names without _0.0
_copy_default_outfiles(options.output_path)
_copy_default_outfiles(output_path)

#TODO: HOPE THAT GETLLM DOES A BETTER JOB
LOG.warn("Cleaning files of NAN! This should not be necessary!")
all_files = os.listdir(options.output_path)
all_files = os.listdir(output_path)
tfs_utils.remove_nan_from_files(
[os.path.join(options.output_path, f) for f in all_files], replace=True)
[os.path.join(output_path, f) for f in all_files], replace=True)

# adding data
betalistx = {}
Expand All @@ -234,9 +233,9 @@ def main(**kwargs):

for dpp in files_dict.keys():
LOG.debug("Loading driven data for dpp {:f}".format(dpp))
betx_path = _join_with_output_path(options.output_path, 'getbetax{ext:s}'.format(ext=_ext(dpp)))
bety_path = _join_with_output_path(options.output_path, 'getbetay{ext:s}'.format(ext=_ext(dpp)))
couple_path = _join_with_output_path(options.output_path, 'getcouple{ext:s}'.format(ext=_ext(dpp)))
betx_path = _join_with_output_path(output_path, 'getbetax{ext:s}'.format(ext=_ext(dpp)))
bety_path = _join_with_output_path(output_path, 'getbetay{ext:s}'.format(ext=_ext(dpp)))
couple_path = _join_with_output_path(output_path, 'getcouple{ext:s}'.format(ext=_ext(dpp)))

betx = metaclass.twiss(betx_path)
bety = metaclass.twiss(bety_path)
Expand All @@ -257,16 +256,16 @@ def main(**kwargs):
modeld = metaclass.twiss(options.twissfile)

try:
betaxf_path = _join_with_output_path(options.output_path, 'getbetax_free{ext:s}'.format(ext=_ext(dpp)))
betaxf_path = _join_with_output_path(output_path, 'getbetax_free{ext:s}'.format(ext=_ext(dpp)))
betxf = metaclass.twiss(betaxf_path)
LOG.debug("Loaded betax free data from '{:s}".format(betaxf_path))


betayf_path = _join_with_output_path(options.output_path, 'getbetay_free{ext:s}'.format(ext=_ext(dpp)))
betayf_path = _join_with_output_path(output_path, 'getbetay_free{ext:s}'.format(ext=_ext(dpp)))
betyf = metaclass.twiss(betayf_path)
LOG.debug("Loaded betay free data from '{:s}".format(betayf_path))

couplef_path = _join_with_output_path(options.output_path, 'getcouple_free{ext:s}'.format(ext=_ext(dpp)))
couplef_path = _join_with_output_path(output_path, 'getcouple_free{ext:s}'.format(ext=_ext(dpp)))
couplef = metaclass.twiss(couplef_path)
LOG.debug("Loaded coupling free data from '{:s}".format(couplef_path))
except IOError:
Expand Down Expand Up @@ -296,14 +295,14 @@ def main(**kwargs):

LOG.debug("Getting Driven beta")
# H
fileobj = _chromFileWriter('beta', _join_with_output_path(options.output_path, "chrombetax" + _ext()), 'H')
fileobj = _chromFileWriter('beta', _join_with_output_path(output_path, "chrombetax" + _ext()), 'H')
bpms = bpm_util.intersect(listx)
bpms = bpm_util.model_intersect(bpms, modeld)
_do_lin_reg_bet(fileobj, files_dict.keys(), betalistx, bpms, "H", zerobx, modeld)
del fileobj

# V
fileobj = _chromFileWriter('beta', _join_with_output_path(options.output_path, "chrombetay" + _ext()), 'V')
fileobj = _chromFileWriter('beta', _join_with_output_path(output_path, "chrombetay" + _ext()), 'V')
bpms = bpm_util.intersect(listy)
bpms = bpm_util.model_intersect(bpms, modeld)
_do_lin_reg_bet(fileobj, files_dict.keys(), betalisty, bpms, "V", zeroby, modeld)
Expand All @@ -312,7 +311,7 @@ def main(**kwargs):


LOG.debug("Getting Driven coupling")
fileobj = _chromFileWriter('coupling', _join_with_output_path(options.output_path, "chromcoupling" + _ext()), '')
fileobj = _chromFileWriter('coupling', _join_with_output_path(output_path, "chromcoupling" + _ext()), '')
bpms = bpm_util.intersect(listc)
bpms = bpm_util.model_intersect(bpms, modeld)
_do_linreg_coupling(couplelist, bpms, files_dict.keys(), fileobj)
Expand All @@ -326,14 +325,14 @@ def main(**kwargs):
LOG.debug("Getting Free beta")
# H
fileobj = _chromFileWriter('beta',
_join_with_output_path(options.output_path, "chrombetax_free" + _ext()), 'H')
_join_with_output_path(output_path, "chrombetax_free" + _ext()), 'H')
bpms = bpm_util.intersect(listxf)
bpms = bpm_util.model_intersect(bpms, modelf)
_do_lin_reg_bet(fileobj, files_dict.keys(), betalistxf, bpms, "H", zerobxf, modelf)

# V
fileobj = _chromFileWriter('beta',
_join_with_output_path(options.output_path, "chrombetay_free" + _ext()), 'V')
_join_with_output_path(output_path, "chrombetay_free" + _ext()), 'V')
bpms = bpm_util.intersect(listyf)
bpms = bpm_util.model_intersect(bpms, modelf)
_do_lin_reg_bet(fileobj, files_dict.keys(), betalistyf, bpms, "V", zerobyf, modelf)
Expand All @@ -342,7 +341,7 @@ def main(**kwargs):

LOG.debug("GettingFree coupling")
fileobj = _chromFileWriter('coupling',
_join_with_output_path(options.output_path, "chromcoupling_free" + _ext()), '')
_join_with_output_path(output_path, "chromcoupling_free" + _ext()), '')
bpms = bpm_util.intersect(listcf)
bpms = bpm_util.model_intersect(bpms, modelf)
_do_linreg_coupling(couplelistf, bpms, files_dict.keys(), fileobj)
Expand Down Expand Up @@ -414,9 +413,11 @@ def _create_models_by_madx(accel_inst, dpps):
model_creator = creator.CREATORS[accel_inst.NAME]["nominal"]
model_creator.prepare_run(accel_inst, accel_inst.model_dir)
madx_script = accel_inst.get_multi_dpp_job(dpps)
model_dir = os.path.abspath(accel_inst.model_dir)
model_creator.run_madx(madx_script,
logfile=os.path.join(accel_inst.model_dir, "w_analysis_multidpp.log"),
writeto=os.path.join(accel_inst.model_dir, "w_analysis_multidpp.madx"),
logfile=os.path.join(model_dir, "w_analysis_multidpp.log"),
writeto=os.path.join(model_dir, "w_analysis_multidpp.madx"),
cwd=model_dir
)


Expand Down
13 changes: 7 additions & 6 deletions model/model_creators/lhc_model_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ def prepare_run(cls, lhc_instance, output_path):
else:
os.symlink(file_path, error_deffs_path)

if lhc_instance.YEAR in ["2022", "2023"] and not os.path.exists(
output_path + "/acc-models-lhc"
):
os.symlink(
"/afs/cern.ch/eng/acc-models/lhc/" + lhc_instance.YEAR, output_path + "/acc-models-lhc"
)

@classmethod
def _prepare_fullresponse(cls, lhc_instance, output_path):
with open(lhc_instance.get_iteration_tmpl()) as textfile:
Expand Down Expand Up @@ -180,12 +187,6 @@ class LhcSegmentCreator(model_creator.ModelCreator):
def get_madx_script(cls, lhc_instance, output_path):
with open(lhc_instance.get_segment_tmpl()) as textfile:
madx_template = textfile.read()
if lhc_instance.YEAR in ["2022", "2023"] and not os.path.exists(
output_path + "/acc-models-lhc"
):
os.symlink(
"/afs/cern.ch/eng/acc-models/lhc/" + lhc_instance.YEAR, output_path + "/acc-models-lhc"
)
replace_dict = {
"LIB": lhc_instance.MACROS_NAME,
"MAIN_SEQ": lhc_instance.load_main_seq_madx(),
Expand Down
5 changes: 3 additions & 2 deletions model/model_creators/model_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,12 @@ def prepare_run(cls, acc_instance, output_path):
cls._prepare_fullresponse(acc_instance, output_path)

@staticmethod
def run_madx(madx_script, logfile=None, writeto=None):
def run_madx(madx_script, logfile=None, writeto=None, cwd=None):
madx_wrapper.resolve_and_run_string(
madx_script,
output_file=writeto,
log_file=logfile
log_file=logfile,
cwd=cwd
)


Expand Down