fix: resolve circular import when package renamed to other names #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: resolve circular import when package renamed to other names (like "pygpc_new")
When renaming the package from "pygpc" to "pygpc_new" on the HPC, importing
`pygpc_new` resulted in:
ImportError: cannot import name 'Beta' from partially initialized module
'pygpc_new.RandomParameter' (most likely due to a circular import)
The circular import chain was:
__init__.py → Problem.py → RandomParameter.py → BasisFunction.py
→ Grid.py → RandomParameter.py (Beta)
After investigation, `BasisFunction.py` did not actually use any class or
function from `Grid.py`. Therefore, the import of `Grid` in
`BasisFunction.py` was unnecessary and has been removed. This breaks the
circular dependency and allows successful import of `pygpc_new`.
Note from Chatgpt:
- In the original `pygpc`, the same circular dependency existed, but Python's
import order and `sys.modules` cache happened to resolve it silently.
- Renaming the package changed the module keys in `sys.modules` and exposed
the underlying circular import that previously "passed by accident".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: resolve circular import when package renamed to other names (like "pygpc_new")
When renaming the package from "pygpc" to "pygpc_new" on the HPC, importing
pygpc_newresulted in:The circular import chain was:
After investigation,
BasisFunction.pydid not actually use any class or function fromGrid.py. Therefore, I suspect that the import ofGridinBasisFunction.pyis unnecessary and the import has been removed. This breaks the circular dependency and allows successful import ofpygpc_new.It should be noted that in the original
pygpc, the circular dependency also existed but happened to pass silently.After renaming to other names like
pygpc_new, the underlying issue was exposed and caused the failure.