Fix aaline width and blend conflict #3510
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw 2 potential fixes for this situation:
fix 1: make width keyword only, put it after the blend arg, announce the API as new in 2.5.6 and pretend nothing happened in 2.5.[3-5]
fix 2: roll with whatever we have right now. This somehow works out because old code doing
blend=1
orblend=True
would now meanwidth=1
which is equivalent. We just need to add compat code that handleswidth <= 0
likewidth=1
. We can then advertise that the "width argument replaces the blend argument" and old code doesn't break too bad.