Skip to content

Show available tasks if not provided in relbench example #10281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2025
Merged

Conversation

puririshi98
Copy link
Contributor

while adding this to our CI i noticed if you dont pass task it fails and then i had to go to https://github.com/snap-stanford/relbench/blob/main/relbench/tasks/__init__.py to find the options. some help strings would be good.
I am going to submit a followup PR soon

Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to set it to None so that users will always see the available tasks in the check below.

@akihironitta
Copy link
Member

@puririshi98 Thanks for setting up CI to test this on your side! Feel free to merge this :)

@akihironitta akihironitta changed the title help for task Show available tasks if not provided May 17, 2025
@akihironitta akihironitta changed the title Show available tasks if not provided Show available tasks if not provided in relbench example May 17, 2025
@puririshi98 puririshi98 merged commit 272a844 into master May 17, 2025
18 of 20 checks passed
@puririshi98 puririshi98 deleted the help branch May 17, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants