Skip to content

Let pre-commit fix formatting issue in master #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2025
Merged

Let pre-commit fix formatting issue in master #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8915e95
empty
akihironitta Feb 9, 2025
42a6904
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 9, 2025
2e118c8
update
akihironitta Feb 9, 2025
ea722ff
Merge branch 'aki/pre-commit' of github.com:pyg-team/pytorch-frame in…
akihironitta Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ jobs:
examples/**
README.md
CHANGELOG.md
.github/workflows/changelog.yml
.github/workflows/dependabot-auto-merge.yml
.github/workflows/documentation.yml
.github/workflows/labeler.yml
.github/workflows/linting.yml
.github/workflows/release.yml
Comment on lines +56 to +61
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ignore these since you have then with linter?

pytorch-frame/.pre-commit-config.yaml

Line 32 in 652b573

- id: yamllint

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jirka! What do you mean? I think unit tests should be triggered based on changes in the codebase (and/or other things like pyproject.toml), but we don't need to run unit tests based on any changes in linting.yml.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are rigth :)


- name: Setup packages
if: steps.changed-files-specific.outputs.only_changed != 'true'
Expand Down
26 changes: 14 additions & 12 deletions test/gbdt/test_gbdt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,21 @@
from torch_frame.testing.text_embedder import HashTextEmbedder


@pytest.mark.parametrize('gbdt_cls', [
# TODO: Run CatBoost test on Python 3.13 once supported
# https://github.com/catboost/catboost/issues/2748
pytest.param(
CatBoost,
marks=pytest.mark.skipif(
sys.version_info >= (3, 13),
reason="Not supported on Python 3.13",
@pytest.mark.parametrize(
'gbdt_cls',
[
# TODO: Run CatBoost test on Python 3.13 once supported
# https://github.com/catboost/catboost/issues/2748
pytest.param(
CatBoost,
marks=pytest.mark.skipif(
sys.version_info >= (3, 13),
reason="Not supported on Python 3.13",
),
),
),
XGBoost,
LightGBM,
])
XGBoost,
LightGBM,
])
@pytest.mark.parametrize('stypes', [
[stype.numerical],
[stype.categorical],
Expand Down
Loading