Skip to content

Tighten assert condition in graph break tests #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Tighten assert condition in graph break tests #458

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b4787f
update
akihironitta Sep 26, 2024
dfe4ca4
.
akihironitta Sep 26, 2024
d9c75b7
update
akihironitta Sep 26, 2024
9436ac0
Apply suggestions from code review
akihironitta Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions test/nn/models/test_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from torch_frame.testing import withPackage


@withPackage("torch>=2.1.0")
@withPackage("torch>=2.5.0")
@pytest.mark.parametrize(
"model_cls, model_kwargs, stypes, expected_graph_breaks",
[
Expand All @@ -34,7 +34,7 @@
gamma=0.1,
),
None,
7,
2,
id="TabNet",
),
pytest.param(
Expand All @@ -47,21 +47,21 @@
ffn_dropout=0.5,
),
None,
4,
0,
id="TabTransformer",
),
pytest.param(
Trompt,
dict(channels=8, num_prompts=2),
None,
16,
4,
id="Trompt",
),
pytest.param(
ExcelFormer,
dict(in_channels=8, num_cols=3, num_heads=1),
[stype.numerical],
4,
1,
id="ExcelFormer",
),
],
Expand Down Expand Up @@ -89,4 +89,5 @@ def test_compile_graph_break(
**model_kwargs,
)
explanation = torch._dynamo.explain(model)(tf)
assert explanation.graph_break_count <= expected_graph_breaks
graph_breaks = explanation.graph_break_count
assert graph_breaks == expected_graph_breaks
Loading