Fixing Bug in Version Handling. #410
Merged
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
weihua916
approved these changes
Jun 7, 2024
rusty1s
pushed a commit
to pyg-team/pytorch_geometric
that referenced
this pull request
Jun 14, 2024
I've noticed that the tests with the `withPackage` test decorators
```
@withPackage("torch>=1.12.0")
def test_some_test(...):
. . .
```
are not being executed,
```
SKIPPED [2] test/nn/conv/test_heat_conv.py:10: Package torch>=1.12.0 not
found
SKIPPED [2] test/nn/conv/test_hetero_conv.py:181: Package torch>=2.1.0
not found
SKIPPED [1] test/nn/conv/test_hgt_conv.py:12: Package torch>=1.12.0 not
found
SKIPPED [1] test/nn/conv/test_hgt_conv.py:63: Package torch>=1.12.0 not
found
SKIPPED [1] test/nn/conv/test_hgt_conv.py:114: Package torch>=1.12.0 not
found
```
even though I have torch=2.4.0 installed on my machine. To be precise, I am using Torch version `2.4.0a0+f70bd71a48.nv24.06` which has an unexpected version ID format for the for `pytorch_geometric` .
The proposed PR uses standard [Python version handling](https://packaging.python.org/en/latest/specifications/version-specifiers/), which covers the dev case previously treated separately.
**NOTES:**
- I found and fixed a similar issue in `pytorch_frame`, see [PR#410](pyg-team/pytorch-frame#410).
- When testing the fix for the current PR, I noticed that 113 (=600-483) more tests were run from the `test` directory
```
Befor:========== 5926 passed, 600 skipped, 503 warnings in 535.56s
(0:08:55)
After:========== 13 failed, 6030 passed, 483 skipped, 521 warnings in
596.27s (0:09:56)
```
and 13 of them failed. Similar failures may occur in your CI environment. Please consider this during the PR review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the tests with the
withPackagetest decoratorsare not being executed, even though I have
torch=2.4.0installed on my machine.To be precise, I am using Torch version
2.4.0a0+f70bd71a48.nv24.06which has an unexpected version ID format for the forpytorch-frame.The proposed PR uses standard Python version handling, which covers the
devcase previously treated separately.