Skip to content

Move license from readme to LICENSE #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Apr 27, 2022

No description provided.

Not sure if it's OK to add an addendum like this, but do we need it front & central on the readme?
@max-sixty max-sixty changed the title license Move license from readme to LICENSE Apr 27, 2022
@max-sixty
Copy link
Collaborator Author

I see a few 👍 — but is this def OK? @shoyer maybe this needs your approval

@max-sixty max-sixty requested a review from shoyer April 28, 2022 07:34
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably a good idea, but I didn't do it originally because GitHub does not detect a license as "Apache 2.0" unless the full text matches exactly.

@@ -189,3 +189,32 @@ third-party archives.
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

ADDENDUM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this part (or at least a few words) up to a preface at the top? It's easy to miss addendums

@jhamman
Copy link
Member

jhamman commented Sep 14, 2023

I think this is probably a good idea, but I didn't do it originally because GitHub does not detect a license as "Apache 2.0" unless the full text matches exactly.

Are we sure this is still the case? I'd be in favor of trying this with the caveat that its probably not worth it if github isn't able to detect the apache license.

Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to merge this!

Also, add the license file to the pyproject.toml instead of only the name.

- For less well defined questions or ideas, or to announce other
projects of interest to xarray users, use the [mailing
list](https://groups.google.com/forum/#!forum/xarray).
GitHub](https://github.com/pydata/xarray).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add

[![License](https://img.shields.io/badge/License-Apache_2.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)

To the badges.

(Or maybe link to the new internal license file instead of the Weblink)

@headtr1ck
Copy link
Collaborator

headtr1ck commented Oct 1, 2023

I think the most common way to distribute the Apache2 license is to add the original license UNMODIFIED in a LICENSE file and add a NOTICE file that includes the copyright notice (newer versions omit the years in the copyright) and links to the license file.

This would then also be the place to add the addendum.

(Note: I'm not super familiar with this, but that's what I could find online and explained in the license itself! So maybe someone with more expertise should verify this!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants