-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Move license from readme to LICENSE #6521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Not sure if it's OK to add an addendum like this, but do we need it front & central on the readme?
I see a few 👍 — but is this def OK? @shoyer maybe this needs your approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is probably a good idea, but I didn't do it originally because GitHub does not detect a license as "Apache 2.0" unless the full text matches exactly.
@@ -189,3 +189,32 @@ third-party archives. | |||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
See the License for the specific language governing permissions and | |||
limitations under the License. | |||
|
|||
ADDENDUM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this part (or at least a few words) up to a preface at the top? It's easy to miss addendums
Are we sure this is still the case? I'd be in favor of trying this with the caveat that its probably not worth it if github isn't able to detect the apache license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to merge this!
Also, add the license file to the pyproject.toml
instead of only the name.
- For less well defined questions or ideas, or to announce other | ||
projects of interest to xarray users, use the [mailing | ||
list](https://groups.google.com/forum/#!forum/xarray). | ||
GitHub](https://github.com/pydata/xarray). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add
[](https://opensource.org/licenses/Apache-2.0)
To the badges.
(Or maybe link to the new internal license file instead of the Weblink)
I think the most common way to distribute the Apache2 license is to add the original license UNMODIFIED in a This would then also be the place to add the addendum. (Note: I'm not super familiar with this, but that's what I could find online and explained in the license itself! So maybe someone with more expertise should verify this!) |
No description provided.