PandasIndex.create_variables() hot fix. #10518
Closed
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This hot fix breaks other valid use cases like |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot fix for xarray-contrib/xarray-indexes#25 (comment)
The reason it breaks there is because
PandasIndex.create_variables()relies on the wrapped pandas index (self.index)nameproperty to set the name of the returned coordinate variable. That property is set by default from thedimdimension name inPandasIndex.__init__(), and is renamed inPandasIndex.from_variables()after calling the constructor. PandasIndex subclasses that re-implement.from_variables()may miss the last step, which now triggers an error with #10503.