Skip to content

Update Custom Indexes section in api.rst #10517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025
Merged

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Jul 9, 2025

A couple of xarray-tutorial paths have changed.

@dcherian dcherian enabled auto-merge (squash) July 9, 2025 14:42
dcherian added 2 commits July 9, 2025 08:03
A couple of xarray-tutorial paths have changed.
@dcherian dcherian disabled auto-merge July 9, 2025 15:03
@dcherian dcherian changed the title Fix docs build. Update Custom Indexes section in api.rst Jul 9, 2025
@dcherian dcherian requested a review from scottyhq July 9, 2025 15:25
@scottyhq
Copy link
Contributor

scottyhq commented Jul 9, 2025

A couple of xarray-tutorial paths have changed.

Hmmm, yeah looks like some last minute changes for the scipy 2025 tutorial :) xarray-contrib/xarray-tutorial#334

doc/api.rst Outdated
@@ -1571,12 +1571,22 @@ Custom Indexes
==============
.. currentmodule:: xarray

Default, pandas-backed indexes built-in to Xarray:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about renaming this entire section Custom Indexes -> Indexes, and promoting it up so that it's underneath other core data structures (under Coordinates)

Also a quick update here would be nice https://xray--10517.org.readthedocs.build/en/10517/internals/internal-design.html#internal-design (but that can also happen later as part of #10323)

Copy link
Contributor Author

@dcherian dcherian Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved half of it up, and left the "build new indexes" pieces down where they are now.

The internal design page will require more time than I have now.

Copy link
Contributor

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dcherian dcherian enabled auto-merge (squash) July 9, 2025 16:51
@dcherian dcherian merged commit 271ebe9 into pydata:main Jul 9, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants