Expression not assigned

[DimitriPapadopoulos]

• Closes #xxxx
• Tests added
• User visible changes (including notable bug fixes) are documented in whats-new.rst
• New functions/methods are listed in api.rst

[dcherian]

Suggested change

	# assert obj is not obj.unify_chunks()
	assert obj is not obj.unify_chunks()

I think this may be right

[DimitriPapadopoulos]

The test doesn't work, that's why it has been commented out. I should probably improve the comment in commit 5f93e2d.

Besides I think it should have been:

Suggested change

	# assert obj is not obj.unify_chunks()
	assert obj is not unified

[DimitriPapadopoulos]

Uncommenting the test demonstrates the CI issue:

=========================== short test summary info ============================
FAILED xarray/tests/test_dask.py::test_unify_chunks_shallow_copy[<lambda>0-obj0] - assert <xarray.Dataset> Size: 9kB\nDimensions:  (x: 10, y: 20, z: 4)\nCoordinates:\n  * x        (x) int64 80B 0 1 2 3 4 5 6 7 8...2B 1 1 1 1\n    e        (x, y) int64 2kB 100 101 102 103 104 105 ... 124 125 126 127 128\nAttributes:\n    test:     test is not <xarray.Dataset> Size: 9kB\nDimensions:  (x: 10, y: 20, z: 4)\nCoordinates:\n  * x        (x) int64 80B 0 1 2 3 4 5 6 7 8...2B 1 1 1 1\n    e        (x, y) int64 2kB 100 101 102 103 104 105 ... 124 125 126 127 128\nAttributes:\n    test:     test
FAILED xarray/tests/test_dask.py::test_unify_chunks_shallow_copy[<lambda>0-obj1] - AssertionError: assert <xarray.DataArray 'a' (x: 10, y: 20)> Size: 2kB\narray([[1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1....2 14 16 18\n    cxy      (x, y) int64 2kB 0 0 0 0 0 0 0 ... 1026 1035 1044 1053 1062 1071\nAttributes:\n    test:     test is not <xarray.DataArray 'a' (x: 10, y: 20)> Size: 2kB\narray([[1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1., 1....2 14 16 18\n    cxy      (x, y) int64 2kB 0 0 0 0 0 0 0 ... 1026 1035 1044 1053 1062 1071\nAttributes:\n    test:     test
= 2 failed, 19121 passed, 1041 skipped, 195 xfailed, 33 xpassed, 2864 warnings in 348.89s (0:05:48) =
Error: Process completed with exit code 1.

See for example https://github.com/pydata/xarray/actions/runs/16135835929/job/45531837533?pr=10507.