Raise if Index.create_variables returns more variables than passed in through set_xindex
#10503
+71
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! given the discussion on the issue, can you change to raise an error if extra variables are returned please? That will be a good improvement until we decide to change behaviour |
|
@dcherian I have already implemented it accordingly, as I after then commented (#10499 (comment)) on issue too. I think you can review it. |
dcherian
changed the title
create_variables returns more variables than passed in through set_xindex
dcherian
changed the title
create_variables returns more variables than passed in through set_xindexIndex.create_variables returns more variables than passed in through set_xindex
|
Nice, can you add a test to https://github.com/pydata/xarray/blob/main/xarray/tests/test_indexes.py please |
|
@dcherian i have added the tests. |
dcherian
reviewed
Jul 8, 2025
dcherian
reviewed
Jul 8, 2025
dcherian
reviewed
Jul 8, 2025
dcherian
reviewed
Jul 8, 2025
dcherian
reviewed
Jul 8, 2025
dcherian
reviewed
Jul 8, 2025
dcherian
reviewed
Jul 9, 2025
|
|
||
| def create_variables(self, variables=None): | ||
| if variables is None: | ||
| # For Coordinates.from_xindex(), return all variables the index can create |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstPreviously,
set_xindexsilently ignored any extra variables returned by custom indexes'create_variablesmethod, only adding variables that matched the original coordinate names. This prevented custom indexes from providing additional computed variables, limiting their usefulness for advanced indexing scenarios like weather forecasting where derived coordinates are needed.This change modifies
set_xindexindataset.pyto add all variables returned bycreate_variables(), not just those matching coordinate names. The implementation simply iterates through all returned variables instead of filtering by coordinate names.The fix enables custom indexes to provide computed variables while maintaining full backward compatibility. Existing code continues to work unchanged, but custom indexes can now return additional variables that will be properly added to the dataset, resolving the silent ignoring behavior that was confusing to users.