WIP: Support additional forges #2215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Matous <m@matous.dev>
Signed-off-by: Martin Matous <m@matous.dev>
Signed-off-by: Martin Matous <m@matous.dev>
Signed-off-by: Martin Matous <m@matous.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR contains support for additional SW forges. Project source link in header, link shortening, and edit button are separated by commit.
I had some trouble with SVG assets due to having little experience with CSS or Webpack. How should I bundle them? I couldn't figure out the correct Webpack config, so they're inline for now.
Should I grayscale the icon link in header considering the note about not styling social media icons due to a11y in
_icon-links.css?pydata-sphinx-theme/src/pydata_sphinx_theme/assets/styles/components/_icon-links.scss
Line 47 in 3e74810
How should I handle Codeberg shortlink icon and dark/light mode? The inlined one changes colors in the exact oposite way than I'd like (dark blue on dark) and its other version works fine on dark but disappears on light theme. I tried two separate defs in
_icons.scssinsidehtml[data-theme="dark|light"](mentioned in https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/styling.html#color-variables) but that didn't work.I also noticed a function being called unnecessarily and fixed that in a separate and a bit offtopic commit. I can send that one in a different PR, if you'd like.
Requested in #2201