-
Notifications
You must be signed in to change notification settings - Fork 1k
Add settings
to Model base class
#2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Change SummaryEnhanced the Model base class by introducing a settings field and updating the documentation to reflect the new settings hierarchy.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svilupp Thanks for working on this!
Fixes #2119
The implementation follows the suggestion by @DouweM
This PR:
settings
field in the Model classmodel settings < agent model settings < run-specific model settings
# Issues Encountered
I dediced on the following behaviour -- any thoughts?
settings
, so I had to change the field definition to beself.settings: ModelSettings | InstrumentationSettings | None = settings
settings
field for API consistencyNext Steps
agent.run()
) to be a separate utility with its own tests?