Skip to content

Fix bedrock description handling #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix bedrock description handling #1507

wants to merge 1 commit into from
+9 −6

Conversation

dmontagu
Copy link
Contributor

Before merging this we should probably make the description field on pydantic_ai.tools.ToolDefinition optional, and handle None properly on every other model.

@github-actions GitHub Actions
Copy link

Docs Preview

commit: 4269d90
Preview URL: https://a2056c89-pydantic-ai-previews.pydantic.workers.dev

@DouweM DouweM marked this pull request as draft April 30, 2025 19:14
@DouweM
Copy link
Contributor

DouweM commented Apr 30, 2025

@dmontagu Making description optional sounds reasonable, and would let us stop passing '' for MCP tools that don't have one. Are you planning to implement that here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees

@dmontagu dmontagu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmontagu @DouweM @Kludex