Skip to content

Fix example in upgrade guide #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

alamb
Copy link

@alamb alamb commented May 21, 2025

I think this will fix the CI test failure

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 21, 2025
Copy link

hyperlint-ai bot commented May 21, 2025

PR Change Summary

Updated the upgrade guide to fix an example related to the ListingOptions configuration.

  • Modified the example for ListingOptions to include the correct usage of ParquetFormat.
  • Clarified the requirement to explicitly set the collect_stat option.

Modified Files

  • docs/source/library-user-guide/upgrading.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@adriangb adriangb merged commit c06c41b into pydantic:collect-stats-off May 21, 2025
6 checks passed
adriangb added a commit that referenced this pull request May 21, 2025
…fig (apache#16080)

* fix

* add a test

* fmt

* add to upgrade guide

* fix tests

* fix test

* fix test

* fix ci

* Fix example in upgrade guide (#29)

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants