Skip to content

fix: fix issues with SliderLabel strong reference #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix issues with SliderLabel strong reference #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/superqt/sliders/_labeled.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

import contextlib
from enum import IntEnum, IntFlag, auto
from functools import partial
from typing import Any, Iterable, overload
from typing import Any, Callable, Iterable, overload

from qtpy import QtGui
from qtpy.QtCore import Property, QPoint, QSize, Qt, Signal
Expand Down Expand Up @@ -571,8 +570,13 @@
lbl.deleteLater()
self._handle_labels.clear()
for n, val in enumerate(self._slider.value()):
_cb = partial(self._slider.setSliderPosition, index=n)
s = SliderLabel(self._slider, parent=self, connect=_cb)
# so gross... fix me
s = SliderLabel(
self._slider,
parent=self,
connect=self._on_slider_label_edited,
index=n,
)
s.editingFinished.connect(self.editingFinished)
s.setValue(val)
self._handle_labels.append(s)
Expand All @@ -581,6 +585,10 @@
label.setValue(val)
self._reposition_labels()

def _on_slider_label_edited(self, pos: float) -> None:
idx = getattr(self.sender(), "_index", 0)
self._slider.setSliderPosition(pos, idx)

Check warning on line 590 in src/superqt/sliders/_labeled.py

View check run for this annotation

Codecov / codecov/patch

src/superqt/sliders/_labeled.py#L589-L590 

Added lines #L589 - L590 were not covered by tests

def _on_range_changed(self, min: int, max: int) -> None:
if (min, max) != (self._slider.minimum(), self._slider.maximum()):
self._slider.setRange(min, max)
Expand Down Expand Up @@ -640,12 +648,14 @@
def __init__(
self,
slider: QSlider,
parent=None,
alignment=Qt.AlignmentFlag.AlignCenter,
connect=None,
parent: QWidget | None = None,
alignment: Qt.AlignmentFlag = Qt.AlignmentFlag.AlignCenter,
connect: Callable | None = None,
index: int = 0,
) -> None:
super().__init__(parent=parent)
self._slider = slider
self._index = index
self.setFocusPolicy(Qt.FocusPolicy.ClickFocus)
self.setMode(EdgeLabelMode.LabelIsValue)
self.setDecimals(0)
Expand Down
Loading