use updated sip files from from char101 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
commented
Mar 8, 2025
|
Thanks. I have no preference with whitespace formatting as long as it is consistent. Also I forgot to fix the formatting on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9
@char101, Thanks for these. This updates just uses your files directly (with the exception, for the moment, of the
ads.sip, until i/we decide on whether to add QtAds inside the PyQt6 namespace).I've left all your whitespace changes in as well. It's all the same to me and perhaps will make your life easier if you'd like to contribute in the future. I also added you as an author to this commit, hope that's ok with you