Light mode button fix #553
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with hoverlabel_bgcolor keyword argument
Removed extra white space. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Used CSS variable instead of hardcoded "white" value. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the primary theme color for better readability in light mode and adjusts the hover label styling in the translation graph.
- Lightens the
--pyos-color-primaryCSS variable for improved button contrast. - Sets hover label background to the page’s body background and fixes hover label font color.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| _static/pyos.css | Updated --pyos-color-primary to a lighter shade |
| _ext/translation_graph.py | Added hoverlabel_bgcolor and hoverlabel_font_color settings |
| @@ -146,6 +146,8 @@ def run(self): | |||
| fig.update_layout( | |||
| paper_bgcolor="rgba(0,0,0,0)", | |||
| plot_bgcolor="rgba(0,0,0,0)", | |||
| hoverlabel_bgcolor="var(--bs-body-bg)", | |||
| hoverlabel_font_color="rgba(255, 255, 255, 1)", | |||
There was a problem hiding this comment.
Hardcoding the hover label font color to white can lead to poor contrast on a light background. Consider using the body text color variable (var(--bs-body-color)) or another dynamic value to ensure readability across themes.
Suggested change
| hoverlabel_font_color="rgba(255, 255, 255, 1)", | |
| hoverlabel_font_color="var(--bs-body-color)", |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the CSS file so that the button is more readable. Here's the issue number for reference. #533