Fixed hover background color issue #539
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized that in the dark mode, the hover text looks a little bit hard to read, so I might edit that as well so that it is consistent across both light and dark modes. |
…with hoverlabel_bgcolor keyword argument
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the hover background color issue in the Translation Guide’s interactive graph by explicitly setting hover label styling.
- Added
hoverlabel_bgcolorto ensure hover labels have a visible background. - Added
hoverlabel_font_colorto guarantee hover text is readable. - Verified that no docs tests were broken by running
nox docs-test.
Removed extra white space. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Used CSS variable instead of hardcoded "white" value. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@all-contributors please add @hfactor13 for code, review |
|
I've put up a pull request to add @hfactor13! 🎉 |
lwasser
reviewed
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the hover background issue for the Translation Guide for the Python Packaging Guide (Issue #532). I also ran the
nox docs-testcommand, and everything came back successful. Feel free to let me know if there's anything else I should include with this pull request.