add mypy support #106
Open
add mypy support #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneakers-the-rat
force-pushed
the
add-mypy
branch
from
006659d to
932f77c
Compare
|
Oh, thank you for this. I had this on my list because all of the mypy stuff is commented out in the "full" version of the template. I'll leave to Moritz for review I just wanted to thank you for this!! Also, get your poster done 🙃 |
Midnighter
approved these changes
Jul 21, 2025
| @@ -151,11 +151,11 @@ use_precommit: | |||
| default: "{% if template_mode != 'minimal' %}yes{% else %}no{% endif %}" | |||
| help: "Do you want to pre-commit hooks to format your code on save?" | |||
|
|
|||
| use_types: | |||
| use_mypy: | |||
There was a problem hiding this comment.
I originally went with use_types, as folks might want to run pyright or another alternative to mypy. It's fair to commit to mypy, though, especially as this is targeted more at beginners.
| """) | ||
|
|
||
| root = generated(use_hatch_envs=use_hatch_envs, use_mypy=True) | ||
| pkg_path = root / "src" / "alien_clones" |
There was a problem hiding this comment.
Can the name be gotten from the generated project somehow? Would be better than hard-coding it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #100
my nerves are shot and i am procrastinating making my scipy posters badly
added a basic mypy config, these are just the config settings i like, so requesting review from @Midnighter who had the previous config in there. took out pydantic-specific stuff bc i figure we don't want to assume people will be using pydantic.
i also renamed the option from
use_typetouse_mypyand changed the prompt text accordingly - everyone should use type annotations :) and also this switch does just enable/disable mypy anyway. i still don't really like how pydoclint has no option for "ignore type annotations in function signatures" and it must be either "all functions must have type signatures" or "no functions may have type signatures" - that's enough of a problem for me that i wouldn't use pydoclint and by proxy this template, but a problem for another time.other stuff:
FBT001rule in test code which i think is silly - it forbids the presence of any positional boolean variables. like ok maybe in some circumstances like the ones they cite in the rule explanation are a code smell but banning an entire type from signatures is overkill, especially in tests.