Skip to content

Fix CI PMS Docker image caching #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Apr 13, 2025

Description

Docker manifest v2 doesn't provide the digest hash. It is just calculated as the SHA256 hash of the manifest.

Ref: https://stackoverflow.com/a/78711220

Also always cache the PMS Docker image even if the tests fail.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 force-pushed the bugfix/ci_docker_digest branch from 3771985 to 7eca548 Compare April 13, 2025 02:09
@JonnyWong16 JonnyWong16 changed the title Fix docker digest in CI workflow Fix CI PMS Docker image caching Apr 13, 2025
@JonnyWong16 JonnyWong16 force-pushed the bugfix/ci_docker_digest branch from db1aa23 to c76116f Compare April 13, 2025 02:24
@JonnyWong16 JonnyWong16 merged commit 594d312 into pushingkarmaorg:master Apr 13, 2025
4 of 5 checks passed
@JonnyWong16 JonnyWong16 deleted the bugfix/ci_docker_digest branch April 15, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant