Skip to content

Adopt PEP 639 #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged

Adopt PEP 639 #1517

merged 1 commit into from
Apr 13, 2025

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Apr 12, 2025

Description

/CC @JonnyWong16 Followup to #1484 (comment)
Setuptools v77 added full support for PEP 639 license expressions.

Metadata diff

 ...
-License: BSD-3-Clause
+License-Expression: BSD-3-Clause
 ...
-Classifier: License :: OSI Approved :: BSD License
 ...

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

Comment on lines 28 to -30
[build-system]
requires = ["setuptools", "wheel"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setuptools uses a custom version of wheel so the requirement here isn't used anymore.

Copy link
Collaborator

@JonnyWong16 JonnyWong16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@cdce8p
Copy link
Contributor Author

cdce8p commented Apr 12, 2025

The test failure seems to be unrelated.

@JonnyWong16 JonnyWong16 merged commit 6fb09a3 into pushingkarmaorg:master Apr 13, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants