Skip to content

Refactor use of manual cached attributes #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Apr 9, 2025

Description

Refactor use of manual cached attributes to use the cached data properties added in #1510.

Breaking change:

  • Hub.items property changed to Hub.items() method to mimic the rest of the library.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16
Copy link
Collaborator Author

Requires #1515 to be merged first.

@JonnyWong16 JonnyWong16 force-pushed the feature/refactor_cache_attributes branch from 669cd2c to fd09280 Compare April 13, 2025 01:41
@JonnyWong16 JonnyWong16 merged commit d3dfafd into pushingkarmaorg:master Apr 18, 2025
4 of 5 checks passed
@JonnyWong16 JonnyWong16 deleted the feature/refactor_cache_attributes branch April 18, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant