Skip to content

Patch Alpine #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Patch Alpine #134

merged 1 commit into from
Apr 7, 2025

Conversation

octavonce
Copy link
Collaborator

No description provided.

@octavonce octavonce merged commit 585ef6a into master Apr 7, 2025
10 checks passed
@ivoanjo
Copy link

ivoanjo commented Apr 8, 2025

For what it's worth, while playing with mimalloc I added support for applying local patches to upstream: https://github.com/DataDog/mimalloc_rust/tree/ivoanjo/mimalloc-tweaks .

E.g. https://github.com/DataDog/mimalloc_rust/blob/ivoanjo/mimalloc-tweaks/libmimalloc-sys/build.rs calls into https://github.com/DataDog/mimalloc_rust/blob/ivoanjo/mimalloc-tweaks/libmimalloc-sys/build_custom.rs which then applies every patch in https://github.com/DataDog/mimalloc_rust/tree/ivoanjo/mimalloc-tweaks/libmimalloc-sys/patches before building.

This was only a side-project so I paused the work, but if it would be useful, I'd be happy to open a PR to add this support for patches?

@yuvald-sweet-security
Copy link

Hey
Thanks, I'm also trying to get this change upstreamed (microsoft/mimalloc#1066)

@ivoanjo
Copy link

ivoanjo commented Apr 10, 2025

No worries! Thanks for working on mimalloc_rust, it was really useful in getting my experiments off the ground quickly 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants