Skip to content

(PIE-1643) System Metrics Formatting #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

coreymbe
Copy link
Contributor

Summary

This commit changes the way that system process metrics collected with sar are formatted before being sent to Splunk.

Detailed Description

Updated lib/puppet/application/splunk_hec.rb

  • Refactored the formatting on system metrics to set the name as the key and the value as the value. This allows for better parsing in Splunk.

Original:

name: %user
value: 0.42

New:

%user: 0.42

Checklist

[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title

@coreymbe coreymbe requested a review from a team as a code owner February 13, 2025 23:16
@coreymbe coreymbe force-pushed the PIE-1643-system_metrics_format branch from f120da2 to 6f0caad Compare February 14, 2025 18:16
@coreymbe coreymbe force-pushed the PIE-1643-system_metrics_format branch from 6f0caad to 6541a1c Compare February 14, 2025 18:25
Copy link
Contributor

@actowery actowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment then lgtm

@coreymbe coreymbe merged commit 6d0f2c8 into puppetlabs:main Feb 19, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants