More cloud logging options #927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #927 +/- ##
==========================================
+ Coverage 52.17% 53.00% +0.82%
==========================================
Files 33 33
Lines 4556 4632 +76
==========================================
+ Hits 2377 2455 +78
+ Misses 1986 1981 -5
- Partials 193 196 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EronWright
commented
May 23, 2025
| opts := zap.Options{ | ||
| Development: true, |
There was a problem hiding this comment.
This Development flag is equivalent to debug-level + console format. I think it simplest to simply remove this line in favor of being explciit in Helm, quickstart, and launch.json.
blampe
approved these changes
May 23, 2025
EronWright
commented
May 23, 2025
Comment on lines
+104
to
+105
| klog.SetLogger(logger) | ||
| ctrllog.SetLogger(logger) |
There was a problem hiding this comment.
By configuring the klog backend to use Zap, one avoids having plain log output intermixed with json output. We see the good effects with these two lines:
{"level":"info","ts":"2025-05-23T20:08:41.512Z","msg":"attempting to acquire leader lease pulumi-kubernetes-operator/operator.pulumi.com..."}
{"level":"info","ts":"2025-05-23T20:08:41.516Z","msg":"successfully acquired lease pulumi-kubernetes-operator/operator.pulumi.com"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR tweaks the operator's logging code to write to stdout rather than to stderr, and to support structured json output.
See "Best practices":
The Helm chart now supports the following logging options:
When running the operator in your IDE, the "development mode" is enabled (i.e. debug-level, console format).
Examples
Console Format
JSON Format
{"level":"info","ts":"2025-05-23T20:08:41.331Z","logger":"setup","msg":"Pulumi Kubernetes Operator Manager","version":"v2.0.0"} {"level":"info","ts":"2025-05-23T20:08:41.408Z","logger":"setup","msg":"starting file server for program resource","address":":9090","advertisedAddress":"pulumi-kubernetes-operator.pulumi-kubernetes-operator:80"} {"level":"info","ts":"2025-05-23T20:08:41.408Z","logger":"setup","msg":"starting manager"} {"level":"info","ts":"2025-05-23T20:08:41.408Z","logger":"controller-runtime.metrics","msg":"Starting metrics server"} {"level":"info","ts":"2025-05-23T20:08:41.408Z","logger":"setup","msg":"disabling http/2"} {"level":"info","ts":"2025-05-23T20:08:41.409Z","msg":"starting server","name":"health probe","addr":"[::]:8081"} {"level":"info","ts":"2025-05-23T20:08:41.512Z","msg":"attempting to acquire leader lease pulumi-kubernetes-operator/operator.pulumi.com..."} {"level":"info","ts":"2025-05-23T20:08:41.516Z","msg":"successfully acquired lease pulumi-kubernetes-operator/operator.pulumi.com"}Related issues (optional)
Closes #912