Makefile migration: make build_sdk
#631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-am-tom
added
the
impact/no-changelog-required
This was referenced Jun 11, 2025
|
Did you see https://docs.google.com/document/d/1ftBuHGGb7SErE2WCB-MHbOMVu_VmbF81lxS3e520e3c/edit?tab=t.0#heading=h.u981p2fv4khv? We should probably follow that, or have some more discussion there, so we can have a standard set of makefile targets. |
This was referenced Jun 11, 2025
i-am-tom
changed the title
Makefile migration: make build-sdkMakefile migration: make build_sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #629, this PR lifts
buildSdkinto theMakefile.make buildnow runsbuild_sdk(migrated from the F# file) andbuild_language_host(previouslymake build).