Fix an issue in repo factory remote definition #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hyagi
force-pushed
the
fix-repo-factory-fixture
branch
from
df8aebb to
8d40aeb
Compare
This commit fixes an issue allowing to define a remote in repo factory fixture. The current implementation is not using the "remote" parameter and trying to set it through kwargs (**body) would conflict with the expected remote (first parameter).
git-hyagi
force-pushed
the
fix-repo-factory-fixture
branch
from
8d40aeb to
c9d91c0
Compare
YasenT
approved these changes
Mar 28, 2025
dkliban
approved these changes
Mar 28, 2025
Backport to 0.3: 💚 backport PR created✅ Backport PR branch: Backported as #308 🤖 @patchback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue allowing to define a remote in repo factory fixture. The current implementation is not using the "remote" parameter and trying to set it through kwargs (**body) would conflict with the expected remote (first parameter).