-
Notifications
You must be signed in to change notification settings - Fork 15
Testing the parallelization of test pipeline. #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis PR restructures the Tekton test pipeline by renaming setup tasks, removing redundant debug code, and splitting each plugin’s functional tests into standalone parallel/serial tasks with explicit dependencies, then updating the final push step to wait for all tests to complete. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- There’s a lot of near-identical test tasks for rpm (parallel/serial), pulpcore, maven, npm, and service—consider refactoring into a parameterized Task or shared template to reduce duplication.
- The debug_and_fail function is copy-pasted in every test step; extracting it into a common script or separate step would avoid repetition and make updates easier.
- Task naming and ordering (e.g., setup-test-environment vs setup-test-deps) is inconsistent—standardizing names and execution order would improve readability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a lot of near-identical test tasks for rpm (parallel/serial), pulpcore, maven, npm, and service—consider refactoring into a parameterized Task or shared template to reduce duplication.
- The debug_and_fail function is copy-pasted in every test step; extracting it into a common script or separate step would avoid repetition and make updates easier.
- Task naming and ordering (e.g., setup-test-environment vs setup-test-deps) is inconsistent—standardizing names and execution order would improve readability.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Parallelize and modularize the Tekton test pipeline by renaming setup tasks, splitting functional tests into per-plugin tasks, and updating task ordering.
Enhancements:
setup-test-environment
andsetup-test-deps
push-api-json-files-to-pulp
only after all new test tasks complete