Skip to content

Conversation

decko
Copy link
Member

@decko decko commented Oct 15, 2025

Summary by Sourcery

Parallelize and modularize the Tekton test pipeline by renaming setup tasks, splitting functional tests into per-plugin tasks, and updating task ordering.

Enhancements:

  • Rename core functional test steps to setup-test-environment and setup-test-deps
  • Add separate Tekton tasks for parallel and serial pulp-rpm tests and individual functional tests for pulpcore, pulp-maven, pulp-npm, and pulp-service
  • Adjust the pipeline to run push-api-json-files-to-pulp only after all new test tasks complete

Copy link
Contributor

sourcery-ai bot commented Oct 15, 2025

Reviewer's Guide

This PR restructures the Tekton test pipeline by renaming setup tasks, removing redundant debug code, and splitting each plugin’s functional tests into standalone parallel/serial tasks with explicit dependencies, then updating the final push step to wait for all tests to complete.

File-Level Changes

Change Details Files
Rename initial test setup tasks
  • Rename pulp-functional-tests to setup-test-environment
  • Rename functional-tests to setup-test-deps
.tekton/pulp-deploy-and-test.yaml
Remove redundant inline debug_and_fail function
  • Delete initial debug_and_fail shell function block
.tekton/pulp-deploy-and-test.yaml
Add dedicated Tekton tasks for each plugin’s tests
  • Define test-pulp-rpm-parallel and test-pulp-rpm-serial tasks
  • Define test-pulpcore, test-pulp-maven, test-pulp-npm, test-pulp-service tasks
.tekton/pulp-deploy-and-test.yaml
Introduce shared login, namespace project, and debug logic in each test task
  • Uniform login.sh invocation and NS handling
  • Embedded debug_and_fail function in each new task
.tekton/pulp-deploy-and-test.yaml
Update final push step dependencies
  • Change runAfter to wait for all new test-pulp-* tasks instead of pulp-functional-tests
.tekton/pulp-deploy-and-test.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • There’s a lot of near-identical test tasks for rpm (parallel/serial), pulpcore, maven, npm, and service—consider refactoring into a parameterized Task or shared template to reduce duplication.
  • The debug_and_fail function is copy-pasted in every test step; extracting it into a common script or separate step would avoid repetition and make updates easier.
  • Task naming and ordering (e.g., setup-test-environment vs setup-test-deps) is inconsistent—standardizing names and execution order would improve readability.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- There’s a lot of near-identical test tasks for rpm (parallel/serial), pulpcore, maven, npm, and service—consider refactoring into a parameterized Task or shared template to reduce duplication.
- The debug_and_fail function is copy-pasted in every test step; extracting it into a common script or separate step would avoid repetition and make updates easier.
- Task naming and ordering (e.g., setup-test-environment vs setup-test-deps) is inconsistent—standardizing names and execution order would improve readability.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant