Improve openapi_json fetching fallback #156
Merged
+34
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-psb
force-pushed
the
improve-openapi-spec-fetching
branch
from
49ad192 to
722d21f
Compare
pedro-psb
changed the title
mdellweg
reviewed
Oct 10, 2025
| # Not found locally. Try again fetching from the official remote url | ||
| pulp_docs_git.git.fetch(self.pulpdocs_git_url, "docs-data") | ||
| api_json = pulp_docs_git.git.show( | ||
| f"{remote}/docs-data:data/openapi_json/{component.rest_api}-api.json" |
There was a problem hiding this comment.
What if we try all fetched remotes first before reaching out to the internet?
As a fallback we tried fetching from some git remote, but we didnt' have a guarantee that this was associated with the pulp-docs official remote git url. This applies a more robust approach explicit fetching from that url.
pedro-psb
force-pushed
the
improve-openapi-spec-fetching
branch
from
722d21f to
5790125
Compare
mdellweg
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a fallback we tried fetching from some git remote, but we didnt' have a guarantee that this was associated with the pulp-docs official remote git url. This applies a more robust approach explicit fetching from that url.