Restructure auth #1057
Merged
Restructure auth #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
auth_power
branch
2 times, most recently
from
af2b3c6 to
d006dad
Compare
ggainey
requested changes
Sep 17, 2024
| @@ -0,0 +1 @@ | |||
| Removed the prompt for a username. | |||
There was a problem hiding this comment.
I think we should explicitly call out "you'll need to specify a BasicAuth username in the config now", since this is a pretty visible user-facing change.
There was a problem hiding this comment.
"--username" is also valid. But yes, good idea.
| @@ -0,0 +1,2 @@ | |||
| Changed the way OAuth2 Client Credentials are provided to give the user some choice over the authentication to use. | |||
| The new parameters `--client-id` and `--client-secret` were added and `--username`, `--password` are now restricted to HTTP Basic. | |||
This introduces --client-id and --client-auth. Users can now infer the authentication to use in face of multiple available security proposals.
According to RFC6749 Section 2.3.1 all token servers are required to support http basic auth. Instead supporting the credentials as post data is specified as optional. Furthermore the RCF discourages using the latter.
Auth objects provided by the pulpcli auth provider are memoized. This way, no password needs to be written back to the pulp_ctx variable and the oauth token can be cached in memory for the lifetime of the context.
mdellweg
force-pushed
the
auth_power
branch
from
d006dad to
e9535de
Compare
ggainey
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.