Expand tests to cover more publication options #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quba42
commented
Aug 20, 2025
| --name "${ENTITIES_NAME}_repo" | ||
|
|
||
| if pulp debug has-plugin --name deb --min-version 2.20.0.dev; then | ||
| if pulp debug has-plugin --name deb --specifier ">=2.20.0"; then |
There was a problem hiding this comment.
I think this change fixes the test for newer, but breaks it for older versions...
There was a problem hiding this comment.
Apparently that is not it. Reverting this has no effect on which test pipelines fail.
Locally the tests pass for me.
There was a problem hiding this comment.
It should still use the new --specifier maybe at the cost of bumping the lb on the cli dependency.
quba42
force-pushed
the
checkpoint_tests
branch
from
d960734 to
1ff3060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should add some test coverage for: #169