Stop managing scenario settings #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdellweg Do you think it's worth writing a template 'migration' to ensure these rules apply on older branches? |
I don't know. I fear at the very moment we need to know this configuration thing, we cannot really know which pulpcore version is going to be installed later... |
|
can we move the whole storage config into the scenario settings? |
|
Yes, we can |
pedro-psb
force-pushed
the
remove-storage-template
branch
from
e07c051 to
71342e3
Compare
pedro-psb
changed the title
Some settings are not compatible across different scenarios x branches. To not overcomplicate the managing logic here, from now on each branch must define the scenario settings which is approriate for them.
pedro-psb
force-pushed
the
remove-storage-template
branch
from
71342e3 to
ce57dc1
Compare
|
Test PR: pulp/pulpcore#6871 |
|
Sometimes being explicit is better than trying to be clever. I like this approach. And i think i see it working, because the errors are related to a completely different python 3.11 thing. |
mdellweg
reviewed
Aug 19, 2025
Comment on lines
-68
to
-75
| DEFAULT_FILE_STORAGE = "storages.backends.azure_storage.AzureStorage" | ||
| AZURE_ACCOUNT_KEY = "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==" | ||
| AZURE_ACCOUNT_NAME = "devstoreaccount1" | ||
| AZURE_CONTAINER = "pulp-test" | ||
| AZURE_LOCATION = "pulp3" | ||
| AZURE_OVERWRITE_FILES = True | ||
| AZURE_URL_EXPIRATION_SECS = 120 | ||
| AZURE_CONNECTION_STRING = 'DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://ci-azurite:10000/devstoreaccount1;' |
There was a problem hiding this comment.
Do you want to "move" this information into the default template values?
(I know it only helps a newly templated plugin, but it also serves as some sort of documentation.)
There was a problem hiding this comment.
Also this actually enables it in the ephemeral catdog plugin of this repository. ;)
pedro-psb
force-pushed
the
remove-storage-template
branch
4 times, most recently
from
42eaae8 to
3d74ca0
Compare
pedro-psb
force-pushed
the
remove-storage-template
branch
from
3d74ca0 to
5f4aa46
Compare
mdellweg
reviewed
Aug 19, 2025
Comment on lines
-68
to
-75
| DEFAULT_FILE_STORAGE = "storages.backends.azure_storage.AzureStorage" | ||
| AZURE_ACCOUNT_KEY = "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==" | ||
| AZURE_ACCOUNT_NAME = "devstoreaccount1" | ||
| AZURE_CONTAINER = "pulp-test" | ||
| AZURE_LOCATION = "pulp3" | ||
| AZURE_OVERWRITE_FILES = True | ||
| AZURE_URL_EXPIRATION_SECS = 120 | ||
| AZURE_CONNECTION_STRING = 'DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://ci-azurite:10000/devstoreaccount1;' |
There was a problem hiding this comment.
Also this actually enables it in the ephemeral catdog plugin of this repository. ;)
mdellweg
approved these changes
Aug 19, 2025
pedro-psb
added a commit
to pedro-psb/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977
pedro-psb
added a commit
to pedro-psb/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977
pedro-psb
added a commit
to pedro-psb/pulpcore
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977
dralley
pushed a commit
to pulp/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977
patchback bot
pushed a commit
to pulp/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977 (cherry picked from commit e33cab8)
patchback bot
pushed a commit
to pulp/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977 (cherry picked from commit e33cab8)
dralley
pushed a commit
to pulp/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977 (cherry picked from commit e33cab8)
dralley
pushed a commit
to pulp/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977 (cherry picked from commit e33cab8)
dralley
pushed a commit
to pulp/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977
patchback bot
pushed a commit
to pulp/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977 (cherry picked from commit f3522f7)
patchback bot
pushed a commit
to pulp/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977 (cherry picked from commit f3522f7)
pedro-psb
added a commit
to pulp/pulp_rpm
that referenced
this pull request
Aug 21, 2025
Branches should explicitly set their storage configs. See: pulp/plugin_template#977 (cherry picked from commit f3522f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some settings are not compatible across different scenarios x branches.
To not overcomplicate the managing logic here, from now on each branch
must define the scenario settings which is approriate for them.
Context for storage:
Guides for using storage settings*, based on pulpcore installed:
Case 1)
<3.70Case 2)
>=3.70,<3.85Case 3)
>=3.85*
[legacy storage settings]: based on DEFAULT_FILE_STORAGE
[new storage settings]: based on STORAGES