Skip to content

Fix toolbar example #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

laske185
Copy link
Contributor

@laske185 laske185 commented Jul 14, 2025

Summary

  • fix toolbar example

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@Copilot Copilot AI review requested due to automatic review settings July 14, 2025 12:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the toolbar example by correcting the JSON quoting of the _items prop in both the fenced code block and the inline usage snippet.

  • Updated _items attribute to use single quotes around the JSON string and double quotes inside.
  • Applied the same correction to the main example and the usage section.
Comments suppressed due to low confidence (2)

docs/30-components/toolbar.mdx:22

  • [nitpick] Since the toolbar has no child elements here, consider using a self-closing tag for brevity and to avoid unnecessary whitespace, e.g., <kol-toolbar ... />.
<kol-toolbar _label="Label" _items='[{"_label": "Button"}, {"_href": "#", "_label": "Link"}]'> </kol-toolbar>

docs/30-components/toolbar.mdx:29

  • [nitpick] You can simplify this snippet by converting it to a self-closing tag (e.g., />) since there are no nested children in the example.
        _items='[{"_label": "Button"}, {"_href": "#", "_label": "Link"}]'>

Copy link

@laske185 laske185 linked an issue Jul 14, 2025 that may be closed by this pull request
@laske185 laske185 requested a review from deleonio July 14, 2025 12:37
@deleonio deleonio merged commit 476cdef into main Jul 14, 2025
4 of 5 checks passed
@deleonio deleonio deleted the feature/toolbar-dokumentationsbeispiel-korrigieren branch July 14, 2025 13:28
@publicuibot publicuibot bot locked and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar - Doku überarbeiten
2 participants