Skip to content

Refactor DocumentationVersionHint component and update styles #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

Refactor DocumentationVersionHint component and update styles #307

merged 3 commits into from
Apr 28, 2025

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Apr 27, 2025 •
edited
Loading

  • Simplified the DocumentationVersionHint component by removing KolAlert and restructuring the JSX.
  • Added a new CSS class for version hints with a gradient background and improved text styles.
  • Integrated DocumentationVersionHint into the Navbar component for consistent visibility.
  • Removed the DocumentationVersionHint from the DocItemWrapper to avoid duplication.
  • Added a .prettierrc configuration file for consistent code formatting.

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio force-pushed the update-kolibri-2.2.10 branch 2 times, most recently from d455152 to a2500c5 Compare April 27, 2025 05:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2025 •
edited
Loading

Netlify Draft Deployment
URL: https://680f80c21aeeeb043dee10de--docs-kolibri-public-ui.netlify.app/v2
Logs: https://app.netlify.com/sites/docs-kolibri-public-ui/deploys/680f80c21aeeeb043dee10de

@deleonio deleonio force-pushed the update-kolibri-2.2.10 branch 4 times, most recently from 7dd9481 to baded52 Compare April 28, 2025 03:38
@deleonio deleonio requested a review from sdvg April 28, 2025 03:49
@deleonio deleonio marked this pull request as draft April 28, 2025 03:50
@deleonio deleonio force-pushed the update-kolibri-2.2.10 branch 3 times, most recently from e3ed16f to edcb671 Compare April 28, 2025 04:07
@deleonio
Refactor DocumentationVersionHint component and update styles
2a9897c 
- Simplified the DocumentationVersionHint component by removing KolAlert and restructuring the JSX.
- Updated the styles for version hint to improve visibility and user experience.
- Modified HomepageFeatures to dynamically link to documentation based on VERSION_ID.
- Created a new index page for the homepage with structured layout and buttons for navigation.
- Removed unused DocItem and DocVersionBadge components to clean up the codebase.
- Integrated DocumentationVersionHint into the Navbar for consistent version display.
- Updated TypeScript configuration to include additional types for better type checking.
@deleonio deleonio force-pushed the update-kolibri-2.2.10 branch from edcb671 to 2a9897c Compare April 28, 2025 04:22
@deleonio
Copy link
Contributor Author

Hi @sdvg,

tsc und eslint bekomme ich nicht gefixed ... weiß nicht, wieso das jetzt wegen meinen Änderungen kommt.

PS: Hier ist React 19 installiert und läuft offensichtlich mit unseren Standard-React-Adapter 😄 ?!

@deleonio deleonio linked an issue Apr 28, 2025 that may be closed by this pull request
Website Hinweise und Aufbau ändern #308
Closed
@deleonio deleonio added the v2 label Apr 28, 2025
@deleonio deleonio marked this pull request as ready for review April 28, 2025 14:43
@deleonio deleonio merged commit f8c28de into release/2 Apr 28, 2025
4 checks passed
@deleonio deleonio deleted the update-kolibri-2.2.10 branch April 28, 2025 14:43
@publicuibot publicuibot bot locked and limited conversation to collaborators Apr 28, 2025
@deleonio deleonio restored the update-kolibri-2.2.10 branch April 28, 2025 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg Awaiting requested review from sdvg

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website Hinweise und Aufbau ändern
2 participants
@deleonio @sdvg