Skip to content

Remove: Theme selector, Cheat Sheet references, npmtrends.com iframes #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 5, 2025
Merged

Remove: Theme selector, Cheat Sheet references, npmtrends.com iframes #276

merged 7 commits into from
Feb 5, 2025

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Feb 3, 2025 •
edited
Loading

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@sdvg sdvg linked an issue Feb 3, 2025 that may be closed by this pull request
Deprecate @public-ui/themes public-ui/kolibri#7155
Closed
@sdvg sdvg changed the title 7155 remove themes Remove: Theme selector, Cheat Sheet references, npmtrends.com iframes Feb 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Netlify Draft Deployment
URL: https://67a1f0fc51f81f3fe66384df--docs-kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/docs-kolibri-public-ui/deploys/67a1f0fc51f81f3fe66384df

@sdvg sdvg marked this pull request as ready for review February 4, 2025 10:53
@deleonio deleonio merged commit bdb1c3e into main Feb 5, 2025
3 of 5 checks passed
@deleonio deleonio deleted the 7155-remove-themes branch February 5, 2025 12:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate @public-ui/themes
2 participants
@sdvg @deleonio