Fix AttributeError in Session.prepare_request() when Request.method is None #7061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where
Session.prepare_request()would raise anAttributeErrorwhen called with aRequestobject that hasmethod=None.Problem
When creating a
Requestobject without specifying a method (e.g.,Request(url="https://example.com/")), themethodattribute defaults toNone. Subsequently callingSession.prepare_request()with this request would crash because the code attempted to call.upper()onNone:Solution
Changed the code to default to
"GET"when the method isNone, matching standard HTTP behavior:Changes
"GET"whenrequest.methodisNonetest_prepare_request_with_none_method()to verify the fix and prevent regressionTesting
The new test case verifies that:
Requestobject can be created withmethod=NoneSession.prepare_request()successfully prepares the request without crashing"GET"methodImpact
This is a bug fix that improves robustness and prevents unexpected crashes when using the library. The behavior aligns with HTTP standards where GET is the default method.