fix CVE 2024 47081: manual url parsing leads to netloc credentials leak #6963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danigm
reviewed
Jun 5, 2025
There was a problem hiding this comment.
About the test, I created another test for the same issue in a different PR. So at this point, the issue is fixed and it could be nice to have a test for this case, I'm okay to close my PR if this test is good enough, or keep it if maintainers are okay to have two tests for this case.
src/requests/utils.py
Outdated
|
|
||
| try: | ||
| _netrc = netrc(netrc_path).authenticators(host) | ||
| _netrc = netrc(netrc_path).authenticators(ri.hostname) |
There was a problem hiding this comment.
This is fixed now in main: 96ba401
|
This is another way to test this that is less end to end but I'm open to accepting it here as well |
|
Well OK, there's not much left after merging |
sigmavirus24
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://seclists.org/fulldisclosure/2025/Jun/2
Honestly I have no idea why this lib used
netloc+ manual parsing instead ofhostnameas I can see references tohostnameas early as from the python 2.6 docs.