fix: bare enums serialize with their tags #739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@woodruffw thanks for the issue report and PR, I'll try to take a look later this week! |
|
Gentle ping for review on this! 🙂 |
psastras
approved these changes
Dec 18, 2024
|
@woodruffw sorry looks good and again thank you -- i've rebased and move this here #767 will merge and release |
|
will close this pr but feel free to re-open discussion if needed! |
auto-merge was automatically disabled
December 18, 2024 03:59
Pull request was closed
|
@woodruffw this is available on crates.io https://crates.io/crates/serde-sarif thanks for you work! |
|
Thanks @psastras, I greatly appreciate it! I'll have some follow-up PRs, but this was the big blocker for me 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #738: enums that were previously marked as
serde(untagged)are now marked with#[serde(rename_all = "camelCase")]where appropriate, causing them to serialize as their expected camelCase string equivalents.I've also gone and deduplicated
#[strum(serialize = "...")]where possible, by moving all of the explicit camelCasing to#[strum(serialize_all = "camelCase")].