Skip to content

Commit eeb6daa

Browse files
authored
Merge pull request #40 from prysmex/fix-image-close-icon
fix image close icon
2 parents b90f484 + 5e5c228 commit eeb6daa

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

addon/components/eui-image/index.hbs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
class={{class-names
33
(unless (eq @hasShadow false) "euiImage--hasShadow")
44
componentName="EuiImage"
5-
size=@size
5+
size=@size
66
}}
77
...attributes
88
>
@@ -52,15 +52,15 @@
5252
{{on "click" this.toggleFullscreen}}
5353
>
5454
<img class="euiImage-isFullScreen__img" src={{@url}} alt={{@alt}} />
55-
<EuiIcon
56-
class="euiImage-isFullScreen__icon"
57-
@type="cross"
58-
@color={{if (not (eq @fullScreenIconColor "dark")) "ghost"}}
59-
/>
6055
</button>
6156
<figcaption class="euiImage__caption">
6257
{{@caption}}
6358
</figcaption>
6459
</figure>
60+
<EuiIcon
61+
class="euiImage-isFullScreenCloseIcon"
62+
@type="cross"
63+
@color={{if (not (eq @fullScreenIconColor "dark")) "ghost"}}
64+
/>
6565
</EuiOverlayMask>
6666
{{/if}}

addon/components/eui-overlay-mask/index.hbs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
insertBefore=null
44
}}
55
<div
6-
role="button"
76
class={{class-names
87
"euiOverlayMask"
98
(unless

tests/dummy/app/templates/demo/image.hbs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</EuiPageHeaderSection>
99
</EuiPageHeader>
1010
<EuiPageContent>
11-
<EuiPageContentBody class="euiFlexGroup euiFlexGroup--directionColumn">
11+
<EuiPageContentBody>
1212
<EuiText @color="primary">
1313
Size s
1414
</EuiText>
@@ -21,6 +21,7 @@
2121
@allowFullScreen={{true}}
2222
@fullScreenIconColor="light"
2323
/>
24+
2425
<EuiText @color="accent">
2526
Size m
2627
</EuiText>
@@ -33,6 +34,7 @@
3334
@allowFullScreen={{true}}
3435
@fullScreenIconColor="light"
3536
/>
37+
3638
<EuiText @color="warning">
3739
Size l
3840
</EuiText>
@@ -45,6 +47,7 @@
4547
@allowFullScreen={{true}}
4648
@fullScreenIconColor="light"
4749
/>
50+
4851
<EuiText @color="warning">
4952
Size Custom 300px
5053
</EuiText>

0 commit comments

Comments
 (0)